Fix / favicon paths #181
Closed
Fix / favicon paths #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
langemike
requested review from
ChristiaanScheermeijer,
MelissaDTH and
royschut
ChristiaanScheermeijer
approved these changes
Apr 22, 2024
ChristiaanScheermeijer
force-pushed
the
develop
branch
from
04323b6
to
8df8c30
Compare
langemike
force-pushed
the
fix/favicon-paths
branch
from
45918a0
to
12dec81
Compare
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
langemike
added
pr-submitted
MelissaDTH
approved these changes
Apr 24, 2024
|
Merged in base repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on
@vitejs/plugin-legacyI noticed some incorrect definitions inindex.html.I guess we didn't notice this because the (fallback) favicon.ico gets rendered in the browser.
I also wrote an e2e test, to verify if all favicons with correct paths get rendered in the browser to prevent an issue like this from happening in the future.
Make sure to visit the deploy preview to verify ;)