Fix / header navigation list (accessibility) #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
royschut
reviewed
Apr 5, 2024
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
|
@royschut thanks for you feedback!
Yes. Therefore I suggest submitting this PR isolated. I think there is no other way around it if we want to aim for an adequate solution. |
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
royschut
approved these changes
Apr 8, 2024
ChristiaanScheermeijer
approved these changes
Apr 8, 2024
|
@langemike, can we merge this to the accessibility branch or submit a PR to the public repo? |
@ChristiaanScheermeijer I will do that, after I I fixed some rework bugs. |
langemike
added
pr-submitted
MelissaDTH
approved these changes
Apr 11, 2024
langemike
force-pushed
the
fix/header-nav-buttons
branch
from
fd2545f
to
4a5eac4
Compare
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
langemike
force-pushed
the
fix/header-nav-buttons
branch
from
4a5eac4
to
dc9614c
Compare
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
|
Merged in base repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change wraps header navigation items within a list. We got this feedback from an accessibility auditor.
I did not want to apply "reset" styles to the
<ul>withinLayout.module.scss, because it belongs in theHeader.module.scss. So I refactored the Header component to make this possible. I have also moved the.headerButtonCSS code toHeader.module.scssto separate the concerns.I think we should submit this as an isolated PR to the JW team, because of the small refactor.
Ticket: OTT-1230