Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat / accessibility sprint 4 #171

Closed
wants to merge 5 commits into from
Closed

Conversation

MelissaDTH
Copy link

@MelissaDTH MelissaDTH commented Apr 3, 2024

Description

This pull request includes recent accessibility improvements implemented in the Videodock/ott-web-app fork. It includes validation improvements and an update to the IconButton component, see below:

Implemented fixes

  • Enhances form validation on the Account page
  • Fixes an issue with the old password form where errors persisted after validation
  • Updates the IconButton component to utilise a <button> element instead of a <div> element, this improves its accessibility by providing a more semantically correct representation of a clickable button, ensuring that aria attributes function as intended
    • Also ensures adherence to icon button styling and prevents them from acting as a submit button after the above fix

Commits

  • fix(project): improve form validation on account page
  • fix(project): old password form error after validation
  • fix(a11y): icon button to use button element
  • chore(a11y): adhere icon button styling & don’t act as a submit button

@MelissaDTH MelissaDTH temporarily deployed to Deployment Previews April 3, 2024 13:29 — with GitHub Actions Inactive
@MelissaDTH MelissaDTH changed the base branch from develop to feat/sprint-4 April 3, 2024 13:29
@MelissaDTH MelissaDTH changed the title Feat/accessibility sprint 4 Feat / accessibility sprint 4 Apr 3, 2024
@MelissaDTH MelissaDTH temporarily deployed to Deployment Previews April 4, 2024 13:42 — with GitHub Actions Inactive
@ChristiaanScheermeijer ChristiaanScheermeijer added the working-branch This is a working branch for a collection of tasks label Apr 5, 2024
@ChristiaanScheermeijer ChristiaanScheermeijer changed the base branch from feat/sprint-4 to develop April 5, 2024 10:18
@MelissaDTH MelissaDTH temporarily deployed to Deployment Previews April 11, 2024 10:09 — with GitHub Actions Inactive
@MelissaDTH MelissaDTH added the pr-submitted The PR has been submitted to the OTT Web App repo label Apr 16, 2024
@MelissaDTH
Copy link
Author

Has been merged at the jw-ott-app repo, therefore closed

@MelissaDTH MelissaDTH closed this Apr 22, 2024
@MelissaDTH MelissaDTH deleted the feat/accessibility-sprint-4 branch June 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-submitted The PR has been submitted to the OTT Web App repo working-branch This is a working branch for a collection of tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants