Fix / Improve form validation on account page #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
aria-invalid
attribute on theTextField
component, to ensure it istrue
when an error occurs if a value is inputtedDemoConfigDialog
andPersonalDetailsForm
snapshot files are also updated, where errors are intentionally being passed. As a result,aria-invalid
is correctly set totrue
for these affected fieldsAccount
component, we currently utilise theForm
component. Ideally, it should be refactored to follow theuseForm
flow similar to theRegistrationForm
. However, this is a big refactor. Because of that, we're unable to utilize ahandleBlur
event for validation after a new input (which was originally wanted in the ticket).