Fix / old password form error after validation

[MelissaDTH]

This PR

• Adds a missing translation for when the old password is not correct after submitting the 'Password reset' form (I've used the error message obtained from the API)
• Updates the password fields to include the autocomplete attribute to improve accessibility
• Solves: OTT-1071

[royschut]

You're now trying to match the filled in old password with the new password. That's never what we want, right? The user wants to change it.
We should let the backend validate the old password and just present the api error. You also don't need the translation then.
Edit: last statement was incorrect, you still need the translation. :)

[MelissaDTH]

You're now trying to match the filled in old password with the new password. That's never what we want, right? The user wants to change it. We should let the backend validate the old password and just present the api error. You also don't need the translation then.

Good point regarding the api error. I looked at the way it is currently done with the validation between the 2 new passwords. I will go back to the drawing board!

Update: discussed with Roy that we do need the translations in order to display the error in Spanish as well. We do now however take the 'old password does not match' api error in account and show it accordingly!

[royschut]

Approved, provided you undo the "passwords_do_not_match" update, and put its value into "old_password_does_not_match".

[langemike]

Nice!

Interesting to see that we missed the autocomplete attribute previously for the password field, but these thing can happen ;)

[royschut]

Nice!