Feat / retry reload subscription #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Melissa Hart <[email protected]>
Co-authored-by: Mike van Veenhuijzen <[email protected]>
Co-authored-by: Mike van Veenhuijzen <[email protected]>
royschut
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
refactor(tests): update snapshots
ChristiaanScheermeijer
approved these changes
Feb 28, 2024
royschut
force-pushed
the
feat/retry-reload-subscription
branch
from
d61fa7d
to
617a036
Compare
royschut
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
ChristiaanScheermeijer
force-pushed
the
feat/sprint-3
branch
from
04134a2
to
6e2ba61
Compare
ChristiaanScheermeijer
changed the base branch from
feat/sprint-3
to
feat/sprint-4
ChristiaanScheermeijer
force-pushed
the
feat/sprint-4
branch
from
08307d0
to
d37905d
Compare
ChristiaanScheermeijer
added
the
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry reload subscription
After buying/updating a subscription, we reload the subscriptions. In some places we use a delay for this, to make sure the backend is ready, but the length of this delay is just a guess of course. I found it a much better and more safe approach to use a retry mechanism in case there is no subscription returned yet. You can still use the (initial) delay, to prevent too many calls (for example after the switchSubscription call, where we had a delay of 7500ms).
Notes