Feat / Documentation sprint 3 #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
langemike
requested review from
ChristiaanScheermeijer,
VincentCouzij,
MelissaDTH and
royschut
langemike
commented
Feb 26, 2024
platforms/web/.env
Outdated
| @@ -4,6 +4,17 @@ APP_PLAYER_ID=M4qoGvUk | |||
| ### Web-only env vars (not sent to common/src/env configureEnv()) | |||
There was a problem hiding this comment.
Should we remove this line / explanation? I think it's incorrect information.
VincentCouzij
approved these changes
Feb 27, 2024
royschut
approved these changes
Feb 28, 2024
|
@ChristiaanScheermeijer I'm awaiting your feedback or approval before I merge :D |
|
Nice @langemike! Let's PR this separately from the sprint-3 branch to the open-source repo. That will make reviewing and applying changes isolated from all the features and fixes easier. |
ChristiaanScheermeijer
force-pushed
the
feat/sprint-3
branch
from
04134a2
to
6e2ba61
Compare
ChristiaanScheermeijer
changed the base branch from
feat/sprint-3
to
feat/sprint-4
ChristiaanScheermeijer
force-pushed
the
feat/workspace-docs-2
branch
from
dad56b1
to
b85f569
Compare
ChristiaanScheermeijer
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
ChristiaanScheermeijer
force-pushed
the
feat/sprint-4
branch
from
08307d0
to
d37905d
Compare
ChristiaanScheermeijer
force-pushed
the
feat/workspace-docs-2
branch
from
b85f569
to
9c26538
Compare
ChristiaanScheermeijer
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
* chore: replace depcheck with knip * chore: run prettier on knip.config.ts * chore: revert to knip entry instead of package exports * chore: fix prettier
ChristiaanScheermeijer
force-pushed
the
feat/workspace-docs-2
branch
from
9c26538
to
2274637
Compare
ChristiaanScheermeijer
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved docs.
.envvariables (I tried to keep it simple)yarn generate-pwa-assetsTicket: https://videodock.atlassian.net/browse/OTT-891