Fix / aria-expanded attribute on icon buttons #590
MelissaDTHAnnotations
10 errors and 1 warning
|
src/containers/Cinema/Cinema.test.tsx > <Cinema> > renders and matches snapshot:
packages/ui-react/src/containers/Cinema/Cinema.test.tsx#L54
Error: Snapshot `<Cinema> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -33,11 +33,11 @@
class="_playerOverlay_555f3c"
>
<div
class="_playerContent_555f3c"
>
- <div
+ <button
aria-label="common:back"
class="_iconButton_0fef65 _backButton_555f3c"
role="button"
tabindex="0"
>
@@ -49,11 +49,11 @@
>
<path
d="M20,11V13H8L13.5,18.5L12.08,19.92L4.16,12L12.08,4.08L13.5,5.5L8,11H20Z"
/>
</svg>
- </div>
+ </button>
<div>
<h1
class="_title_555f3c"
>
Test item title
❯ src/containers/Cinema/Cinema.test.tsx:54:25
|
|
src/containers/Layout/Layout.test.tsx > <Layout /> > renders layout:
packages/ui-react/src/containers/Layout/Layout.test.tsx#L20
Error: Snapshot `<Layout /> > renders layout 1` mismatched
- Expected
+ Received
@@ -16,11 +16,11 @@
skip_to_content
</a>
<div
class="_menu_f4f7a7"
>
- <div
+ <button
aria-controls="sidebar"
aria-expanded="false"
aria-haspopup="true"
aria-label="open_menu"
class="_iconButton_0fef65 _iconButton_f4f7a7"
@@ -39,11 +39,11 @@
/>
<path
d="M3 18h18v-2H3v2zm0-5h18v-2H3v2zm0-7v2h18V6H3z"
/>
</svg>
- </div>
+ </button>
</div>
<nav
class="_nav_f4f7a7"
>
<a
@@ -76,11 +76,11 @@
inert=""
>
<div
class="_heading_577f70"
>
- <div
+ <button
aria-label="close_menu"
class="_iconButton_0fef65"
role="button"
tabindex="0"
>
@@ -96,11 +96,11 @@
<path
d="M0 0h24v24H0z"
fill="none"
/>
</svg>
- </div>
+ </button>
</div>
<nav
class="_group_577f70"
>
<ul>
❯ src/containers/Layout/Layout.test.tsx:20:23
|
|
src/components/CheckoutForm/CheckoutForm.test.tsx > <CheckoutForm> > renders and matches snapshot:
packages/ui-react/src/components/CheckoutForm/CheckoutForm.test.tsx#L35
Error: Snapshot `<CheckoutForm> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -211,11 +211,11 @@
</button>
</div>
</form>
</div>
</div>
- <div
+ <button
aria-label="common:back"
class="_iconButton_0fef65 _dialogBackButton_248199"
role="button"
tabindex="0"
>
@@ -227,8 +227,8 @@
>
<path
d="M20,11V13H8L13.5,18.5L12.08,19.92L4.16,12L12.08,4.08L13.5,5.5L8,11H20Z"
/>
</svg>
- </div>
+ </button>
</div>
</div>
❯ src/components/CheckoutForm/CheckoutForm.test.tsx:35:23
|
|
src/components/Dialog/Dialog.test.tsx > <Dialog> > renders and matches snapshot:
packages/ui-react/src/components/Dialog/Dialog.test.tsx#L18
Error: Snapshot `<Dialog> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -30,11 +30,11 @@
class="_dialog_00d559 _small_00d559"
data-testid="dialog"
role="dialog"
>
Dialog contents
- <div
+ <button
aria-label="close_modal"
class="_iconButton_0fef65 _modalCloseButton_b92d69"
role="button"
tabindex="0"
>
@@ -50,11 +50,11 @@
<path
d="M0 0h24v24H0z"
fill="none"
/>
</svg>
- </div>
+ </button>
</div>
</div>
</div>
</div>
</div>
❯ src/components/Dialog/Dialog.test.tsx:18:25
|
|
src/components/DialogBackButton/DialogBackButton.test.tsx > <DialogBackButton> > renders and matches snapshot:
packages/ui-react/src/components/DialogBackButton/DialogBackButton.test.tsx#L10
Error: Snapshot `<DialogBackButton> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -1,7 +1,7 @@
<div>
- <div
+ <button
aria-label="common:back"
class="_iconButton_0fef65 _dialogBackButton_248199"
role="button"
tabindex="0"
>
@@ -13,7 +13,7 @@
>
<path
d="M20,11V13H8L13.5,18.5L12.08,19.92L4.16,12L12.08,4.08L13.5,5.5L8,11H20Z"
/>
</svg>
- </div>
+ </button>
</div>
❯ src/components/DialogBackButton/DialogBackButton.test.tsx:10:23
|
|
src/components/EditPasswordForm/EditPasswordForm.test.tsx > <EditPasswordForm> > renders and matches snapshot:
packages/ui-react/src/components/EditPasswordForm/EditPasswordForm.test.tsx#L19
Error: Snapshot `<EditPasswordForm> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -33,11 +33,11 @@
value=""
/>
<div
class="_control_e16c1b"
>
- <div
+ <button
aria-label="reset.view_password"
aria-pressed="false"
class="_iconButton_0fef65"
role="button"
tabindex="0"
@@ -50,11 +50,11 @@
>
<path
d="M11.83,9L15,12.16C15,12.11 15,12.05 15,12A3,3 0 0,0 12,9C11.94,9 11.89,9 11.83,9M7.53,9.8L9.08,11.35C9.03,11.56 9,11.77 9,12A3,3 0 0,0 12,15C12.22,15 12.44,14.97 12.65,14.92L14.2,16.47C13.53,16.8 12.79,17 12,17A5,5 0 0,1 7,12C7,11.21 7.2,10.47 7.53,9.8M2,4.27L4.28,6.55L4.73,7C3.08,8.3 1.78,10 1,12C2.73,16.39 7,19.5 12,19.5C13.55,19.5 15.03,19.2 16.38,18.66L16.81,19.08L19.73,22L21,20.73L3.27,3M12,7A5,5 0 0,1 17,12C17,12.64 16.87,13.26 16.64,13.82L19.57,16.75C21.07,15.5 22.27,13.86 23,12C21.27,7.61 17,4.5 12,4.5C10.6,4.5 9.26,4.75 8,5.2L10.17,7.35C10.74,7.13 11.35,7 12,7Z"
/>
</svg>
- </div>
+ </button>
</div>
</div>
<div
class="_helperText_da58e0"
id="helper_text_1235_password"
@@ -87,11 +87,11 @@
value=""
/>
<div
class="_control_e16c1b"
>
- <div
+ <button
aria-label="reset.view_password"
aria-pressed="false"
class="_iconButton_0fef65"
role="button"
tabindex="0"
@@ -104,11 +104,11 @@
>
<path
d="M11.83,9L15,12.16C15,12.11 15,12.05 15,12A3,3 0 0,0 12,9C11.94,9 11.89,9 11.83,9M7.53,9.8L9.08,11.35C9.03,11.56 9,11.77 9,12A3,3 0 0,0 12,15C12.22,15 12.44,14.97 12.65,14.92L14.2,16.47C13.53,16.8 12.79,17 12,17A5,5 0 0,1 7,12C7,11.21 7.2,10.47 7.53,9.8M2,4.27L4.28,6.55L4.73,7C3.08,8.3 1.78,10 1,12C2.73,16.39 7,19.5 12,19.5C13.55,19.5 15.03,19.2 16.38,18.66L16.81,19.08L19.73,22L21,20.73L3.27,3M12,7A5,5 0 0,1 17,12C17,12.64 16.87,13.26 16.64,13.82L19.57,16.75C21.07,15.5 22.27,13.86 23,12C21.27,7.61 17,4.5 12,4.5C10.6,4.5 9.26,4.75 8,5.2L10.17,7.35C10.74,7.13 11.35,7 12,7Z"
/>
</svg>
- </div>
+ </button>
</div>
</div>
<div
class="_helperText_da58e0"
id="helper_text_1235_passwordconfirmation"
❯ src/components/EditPasswordForm/EditPasswordForm.test.tsx:19:23
|
|
src/components/Header/Header.test.tsx > <Header /> > renders header:
packages/ui-react/src/components/Header/Header.test.tsx#L53
Error: Snapshot `<Header /> > renders header 1` mismatched
- Expected
+ Received
@@ -12,11 +12,11 @@
skip_to_content
</a>
<div
class="_menu_f4f7a7"
>
- <div
+ <button
aria-controls="sidebar"
aria-expanded="false"
aria-haspopup="true"
aria-label="open_menu"
class="_iconButton_0fef65 _iconButton_f4f7a7"
@@ -35,21 +35,21 @@
/>
<path
d="M3 18h18v-2H3v2zm0-5h18v-2H3v2zm0-7v2h18V6H3z"
/>
</svg>
- </div>
+ </button>
</div>
<nav
class="_nav_f4f7a7"
>
a
</nav>
<div
class="_actions_f4f7a7"
>
- <div
+ <button
aria-label="Open search"
class="_iconButton_0fef65 _iconButton_f4f7a7 _actionButton_f4f7a7"
role="button"
tabindex="0"
>
@@ -61,11 +61,11 @@
>
<path
d="M15.5 14h-.79l-.28-.27C15.41 12.59 16 11.11 16 9.5 16 5.91 13.09 3 9.5 3S3 5.91 3 9.5 5.91 16 9.5 16c1.61 0 3.09-.59 4.23-1.57l.27.28v.79l5 4.99L20.49 19l-4.99-5zm-6 0C7.01 14 5 11.99 5 9.5S7.01 5 9.5 5 14 7.01 14 9.5 11.99 14 9.5 14z"
/>
</svg>
- </div>
+ </button>
<div
class="_buttonContainer_f4f7a7"
>
<button
aria-haspopup="dialog"
❯ src/components/Header/Header.test.tsx:53:23
|
|
src/components/IconButton/IconButton.test.tsx > <IconButton> > renders and matches snapshot:
packages/ui-react/src/components/IconButton/IconButton.test.tsx#L15
Error: Snapshot `<IconButton> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -1,7 +1,7 @@
<div>
- <div
+ <button
aria-label="Icon button"
class="_iconButton_0fef65"
role="button"
tabindex="0"
>
@@ -15,7 +15,7 @@
<path
d="M0 0h24v24H0z"
fill="none"
/>
</svg>
- </div>
+ </button>
</div>
❯ src/components/IconButton/IconButton.test.tsx:15:23
|
|
src/components/LanguageMenu/LanguageMenu.test.tsx > <LanguageMenu> > renders and matches snapshot:
packages/ui-react/src/components/LanguageMenu/LanguageMenu.test.tsx#L38
Error: Snapshot `<LanguageMenu> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -1,7 +1,7 @@
<div>
- <div
+ <button
aria-controls="language-panel"
aria-expanded="false"
aria-haspopup="menu"
aria-label="language_menu"
class="_iconButton_0fef65"
@@ -18,7 +18,7 @@
<path
d="M11.99 2C6.47 2 2 6.48 2 12s4.47 10 9.99 10C17.52 22 22 17.52 22 12S17.52 2 11.99 2zm6.93 6h-2.95c-.32-1.25-.78-2.45-1.38-3.56 1.84.63 3.37 1.91 4.33 3.56zM12 4.04c.83 1.2 1.48 2.53 1.91 3.96h-3.82c.43-1.43 1.08-2.76 1.91-3.96zM4.26 14C4.1 13.36 4 12.69 4 12s.1-1.36.26-2h3.38c-.08.66-.14 1.32-.14 2 0 .68.06 1.34.14 2H4.26zm.82 2h2.95c.32 1.25.78 2.45 1.38 3.56-1.84-.63-3.37-1.9-4.33-3.56zm2.95-8H5.08c.96-1.66 2.49-2.93 4.33-3.56C8.81 5.55 8.35 6.75 8.03 8zM12 19.96c-.83-1.2-1.48-2.53-1.91-3.96h3.82c-.43 1.43-1.08 2.76-1.91 3.96zM14.34 14H9.66c-.09-.66-.16-1.32-.16-2 0-.68.07-1.35.16-2h4.68c.09.65.16 1.32.16 2 0 .68-.07 1.34-.16 2zm.25 5.56c.6-1.11 1.06-2.31 1.38-3.56h2.95c-.96 1.65-2.49 2.93-4.33 3.56zM16.36 14c.08-.66.14-1.32.14-2 0-.68-.06-1.34-.14-2h3.38c.16.64.26 1.31.26 2s-.1 1.36-.26 2h-3.38z"
fill="currentColor"
/>
</svg>
- </div>
+ </button>
</div>
❯ src/components/LanguageMenu/LanguageMenu.test.tsx:38:23
|
|
src/components/LoginForm/LoginForm.test.tsx > <LoginForm> > renders and matches snapshot:
packages/ui-react/src/components/LoginForm/LoginForm.test.tsx#L50
Error: Snapshot `<LoginForm> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -80,11 +80,11 @@
value=""
/>
<div
class="_control_e16c1b"
>
- <div
+ <button
aria-label="login.view_password"
aria-pressed="false"
class="_iconButton_0fef65"
role="button"
tabindex="0"
@@ -97,11 +97,11 @@
>
<path
d="M11.83,9L15,12.16C15,12.11 15,12.05 15,12A3,3 0 0,0 12,9C11.94,9 11.89,9 11.83,9M7.53,9.8L9.08,11.35C9.03,11.56 9,11.77 9,12A3,3 0 0,0 12,15C12.22,15 12.44,14.97 12.65,14.92L14.2,16.47C13.53,16.8 12.79,17 12,17A5,5 0 0,1 7,12C7,11.21 7.2,10.47 7.53,9.8M2,4.27L4.28,6.55L4.73,7C3.08,8.3 1.78,10 1,12C2.73,16.39 7,19.5 12,19.5C13.55,19.5 15.03,19.2 16.38,18.66L16.81,19.08L19.73,22L21,20.73L3.27,3M12,7A5,5 0 0,1 17,12C17,12.64 16.87,13.26 16.64,13.82L19.57,16.75C21.07,15.5 22.27,13.86 23,12C21.27,7.61 17,4.5 12,4.5C10.6,4.5 9.26,4.75 8,5.2L10.17,7.35C10.74,7.13 11.35,7 12,7Z"
/>
</svg>
- </div>
+ </button>
</div>
</div>
</div>
<a
class="_link_a14c64 _link_7bd5f4"
❯ src/components/LoginForm/LoginForm.test.tsx:50:23
|
|
test (18.x)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|