Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TimmExtractor default transforms #176

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

a1247418
Copy link
Collaborator

TimmExtractor default transformations are now loaded from the timm library. This fixes the defaults for e.g. ViTs and BeiTs.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.23%. Comparing base (9f31bdb) to head (34e04c2).

Files Patch % Lines
thingsvision/core/extraction/extractors.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   76.35%   76.23%   -0.12%     
==========================================
  Files          40       40              
  Lines        2051     2058       +7     
  Branches      262      262              
==========================================
+ Hits         1566     1569       +3     
- Misses        400      404       +4     
  Partials       85       85              
Flag Coverage Δ
unittests 76.23% <60.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LukasMut LukasMut added bug Something isn't working enhancement New feature or request labels Jun 18, 2024
Copy link
Collaborator

@LukasMut LukasMut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasMut LukasMut added this pull request to the merge queue Jun 18, 2024
Merged via the queue into master with commit ad903f3 Jun 18, 2024
3 of 5 checks passed
@LukasMut LukasMut deleted the timm_extractor_transforms_fix branch June 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants