This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
[API-2267] Prettier config #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultz
commented
Sep 20, 2021
| trailingComma: "es5", | ||
| tabWidth: 2, | ||
| semi: true, | ||
| singleQuote: false, |
There was a problem hiding this comment.
For you @therockstorm :)
There was a problem hiding this comment.
👍
These are all just the default values now so is this repo needed?
There was a problem hiding this comment.
Then we can just delete .prettierrc.json files and call it a day!
There was a problem hiding this comment.
Wow, I haven't taken a look at the defaults in awhile.. settings like trailingComma used to default to none, which I always changed to es5. I'll archive this project for now, so we can resurrect it if we disagree with something in Prettier.
danschultz
force-pushed
the
prettier-config
branch
from
bcf9ff7 to
541143f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vertexvis.atlassian.net/browse/API-2267