Added additional checks for inflight flow status #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Inflight flow status check sends a message to the client about flows that are currently in flight. This PR adds an additional check to verify if the flow has already been resolved before sending this check. This helps to avoid sending a status check for a flow that is already resolved which will result in an error state for the flow, even though it is already completed. Also added a flag to disable this entire feature which might be necessary for unusual configurations, while the feature is pretty new and might introduce too much load on busy servers. Also added toolbar to hunt client view.
scudette
added a commit
that referenced
this pull request
Nov 4, 2024
The Inflight flow status check sends a message to the client about flows that are currently in flight. This PR adds an additional check to verify if the flow has already been resolved before sending this check. This helps to avoid sending a status check for a flow that is already resolved which will result in an error state for the flow, even though it is already completed. Also added a flag to disable this entire feature which might be necessary for unusual configurations, while the feature is pretty new and might introduce too much load on busy servers. Also added toolbar to hunt client view.
scudette
added a commit
that referenced
this pull request
Nov 4, 2024
The Inflight flow status check sends a message to the client about flows that are currently in flight. This PR adds an additional check to verify if the flow has already been resolved before sending this check. This helps to avoid sending a status check for a flow that is already resolved which will result in an error state for the flow, even though it is already completed. Also added a flag to disable this entire feature which might be necessary for unusual configurations, while the feature is pretty new and might introduce too much load on busy servers. Also added toolbar to hunt client view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Inflight flow status check sends a message to the client about flows that are currently in flight. This PR adds an additional check to verify if the flow has already been resolved before sending this check. This helps to avoid sending a status check for a flow that is already resolved which will result in an error state for the flow, even though it is already completed.
Also added a flag to disable this entire feature which might be necessary for unusual configurations, while the feature is pretty new and might introduce too much load on busy servers.
Also added toolbar to hunt client view.