Bugfixes: Force timeline message to be a string. #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the timeline message column was not a string, it would not be emitted at all. This PR forces it to be a string. Also handle floats in table output. Update vfilter to fix LIMIT bug in GROUP BY clauses.
misje
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Is this regex perhaps a bit too simple? It will match IP addresses, among other things. What about ^[+-]?([0-9]+([.][0-9]*)?|[.][0-9]+)$? I assume supporting exponents is not important.
There was a problem hiding this comment.
You are correct - This hacky code needs to go - I submitted #3812 to fix this API - might as well do it now.
scudette
added a commit
that referenced
this pull request
Oct 13, 2024
If the timeline message column was not a string, it would not be emitted at all. This PR forces it to be a string. Also handle floats in table output. Update vfilter to fix LIMIT bug in GROUP BY clauses.
scudette
added a commit
that referenced
this pull request
Oct 13, 2024
If the timeline message column was not a string, it would not be emitted at all. This PR forces it to be a string. Also handle floats in table output. Update vfilter to fix LIMIT bug in GROUP BY clauses.
scudette
added a commit
that referenced
this pull request
Oct 13, 2024
If the timeline message column was not a string, it would not be emitted at all. This PR forces it to be a string. Also handle floats in table output. Update vfilter to fix LIMIT bug in GROUP BY clauses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timeline message column was not a string, it would not be emitted at all. This PR forces it to be a string.
Also handle floats in table output.
Update vfilter to fix LIMIT bug in GROUP BY clauses.