Update timeline to display times in user timezone. #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the timeline widget would display all times in UTC but other times in the GUI are displayed in the user's selected timezone. This PR changes this to make the timeline widget display times in the same timezone selected by the user. Also refactored CSV parameter editor to not use editable tables. These were not intuitive as the user had to click on the table to realize they were editable. Also it caused the layout to jump around. This PR fixes it in favor of fixed simple text areas.
scudette
added a commit
that referenced
this pull request
Oct 13, 2024
Previously the timeline widget would display all times in UTC but other times in the GUI are displayed in the user's selected timezone. This PR changes this to make the timeline widget display times in the same timezone selected by the user. Also refactored CSV parameter editor to not use editable tables. These were not intuitive as the user had to click on the table to realize they were editable. Also it caused the layout to jump around. This PR fixes it in favor of fixed simple text areas. Additionally this PR patches the timeline widget to ensure ctrl-wheel zooms in steps of 1 - the default upstream is to jump in steps of 10 which is way too much
scudette
added a commit
that referenced
this pull request
Oct 13, 2024
Previously the timeline widget would display all times in UTC but other times in the GUI are displayed in the user's selected timezone. This PR changes this to make the timeline widget display times in the same timezone selected by the user. Also refactored CSV parameter editor to not use editable tables. These were not intuitive as the user had to click on the table to realize they were editable. Also it caused the layout to jump around. This PR fixes it in favor of fixed simple text areas. Additionally this PR patches the timeline widget to ensure ctrl-wheel zooms in steps of 1 - the default upstream is to jump in steps of 10 which is way too much
scudette
added a commit
that referenced
this pull request
Oct 13, 2024
Previously the timeline widget would display all times in UTC but other times in the GUI are displayed in the user's selected timezone. This PR changes this to make the timeline widget display times in the same timezone selected by the user. Also refactored CSV parameter editor to not use editable tables. These were not intuitive as the user had to click on the table to realize they were editable. Also it caused the layout to jump around. This PR fixes it in favor of fixed simple text areas. Additionally this PR patches the timeline widget to ensure ctrl-wheel zooms in steps of 1 - the default upstream is to jump in steps of 10 which is way too much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the timeline widget would display all times in UTC but other times in the GUI are displayed in the user's selected timezone. This PR changes this to make the timeline widget display times in the same timezone selected by the user.
Also refactored CSV parameter editor to not use editable tables. These were not intuitive as the user had to click on the table to realize they were editable. Also it caused the layout to jump around. This PR fixes it in favor of fixed simple text areas.
Additionally this PR patches the timeline widget to ensure ctrl-wheel zooms in steps of 1 - the default upstream is to jump in steps of 10 which is way too much