Bugfix: Minion did not start the inventory service (#3835)

This causes the minion to fail to start in some situations.

* fixed bug when viewing an empty timeline (e.g. in new timeline).
* Redact compiled_collector_args from the ListFlows() API. This is not
needed by the GUI and when using a hunt, would sometimes cause the API
to exceed the allowed size.

gui/velociraptor/src/components/timeline/timeline.jsx

@@ -932,9 +932,10 @@ export default class TimelineRenderer extends React.Component {
     renderSidebarHeader = getRootProps=>{
         let icon_class = "";
         let icon = "";
-        let enabled = _.filter(this.state.timelines, x=>x.active);
+        let timelines = this.state.timelines || [];
+        let enabled = _.filter(timelines, x=>x.active);
         let all_disabled = enabled.length === 0;
-        let all_enabled = enabled.length === this.state.timelines.length;
+        let all_enabled = enabled.length === timelines.length;
 
         if (all_enabled) {
             icon = "square-check";

gui/velociraptor/src/themes/coolgray-dark.css

@@ -875,6 +875,7 @@ body.coolgray-dark {
 .coolgray-dark .report-viewer pre {
   font-size: var(--font-size-base);
   filter: invert(1);
+  color: var(--color-canvas-background);
   background: rgba(255,255,255,.2);
   border-radius: 4px;
   border: none;

gui/velociraptor/src/themes/github-dimmed-dark.css

@@ -715,13 +715,14 @@ body.github-dimmed-dark {
 
 .github-dimmed-dark .report-viewer pre {
     filter: invert(1);
-  background: rgba(255,255,255,.05);
-  border-radius: 4px;
-  border: none;
-  padding-top: 2px;
-  padding-bottom: 2px;
-  padding-left: 4px;
-  padding-right: 4px;
+    background: rgba(255,255,255,.05);
+    color: var(--color-canvas-background);
+    border-radius: 4px;
+    border: none;
+    padding-top: 2px;
+    padding-bottom: 2px;
+    padding-left: 4px;
+    padding-right: 4px;
 }
 
 .github-dimmed-dark .report-viewer code {

gui/velociraptor/src/themes/midnight.css

@@ -912,12 +912,13 @@ body.midnight {
 }
 
 .midnight .report-viewer pre {
-  border-radius: 0;
-  border: 0.5px solid var(--color-btn-border);
-  padding-top: 2px;
-  padding-bottom: 2px;
-  padding-left: 4px;
-  padding-right: 4px;
+    border-radius: 0;
+    background: rgba(255,255,255,.05);
+    border: 0.5px solid var(--color-btn-border);
+    padding-top: 2px;
+    padding-bottom: 2px;
+    padding-left: 4px;
+    padding-right: 4px;
 }
 
 .midnight .report-viewer code {

gui/velociraptor/src/themes/ncurses-dark.css

@@ -1016,6 +1016,7 @@ body.ncurses-dark {
 .ncurses-dark .report-viewer pre {
   font-weight: normal;
   filter: invert(1) hue-rotate(4rad);
+  color: var(--color-canvas-background);
   border-radius: 0;
   border: none;
   padding-top: 2px;

gui/velociraptor/src/themes/veloci-dark.css

@@ -657,6 +657,7 @@ body.veloci-dark {
 .veloci-dark .report-viewer pre {
   filter: invert(1);
   background: rgba(255,255,255,.05);
+  color: var(--color-canvas-background);
   border-radius: 4px;
   border: none;
   padding-top: 2px;

services/launcher/flows.go

@@ -62,6 +62,10 @@ func (self *Launcher) GetFlows(
 			LoadCollectionContext(ctx, config_obj,
 				client_id, flow_summary.FlowId)
 		if err == nil {
+			// Remove certain fields that are not necessary.
+			if collection_context.Request != nil {
+				collection_context.Request.CompiledCollectorArgs = nil
+			}
 			items = append(items, collection_context)
 		}
 	}

services/notebook/storage_test.go

@@ -4,6 +4,7 @@ import (
 	"time"
 
 	api_proto "www.velocidex.com/golang/velociraptor/api/proto"
+	"www.velocidex.com/golang/velociraptor/json"
 	"www.velocidex.com/golang/velociraptor/services"
 	"www.velocidex.com/golang/velociraptor/vtesting"
 	"www.velocidex.com/golang/velociraptor/vtesting/assert"
@@ -41,6 +42,10 @@ func (self *NotebookManagerTestSuite) TestNotebookStorage() {
 	notebooks, err = notebook_manager.GetAllNotebooks()
 	assert.NoError(self.T(), err)
 
+	if len(notebooks) != 1 {
+		json.Dump(notebooks)
+	}
+
 	assert.Equal(self.T(), 1, len(notebooks))
 	assert.Equal(self.T(), global_notebook.NotebookId, notebooks[0].NotebookId)
 }

services/orgs/services.go

@@ -496,8 +496,7 @@ func (self *OrgManager) startOrgFromContext(org_ctx *OrgContext) (err error) {
 	// Inventory service needs to start before we import built in
 	// artifacts so they can add their tool dependencies.
 	if spec.InventoryService {
-		i, err := inventory.NewInventoryService(
-			ctx, wg, org_config)
+		i, err := inventory.NewInventoryService(ctx, wg, org_config)
 		if err != nil {
 			return err
 		}

services/spec.go

@@ -50,6 +50,7 @@ func MinionServicesSpec() *config_proto.ServerServicesConfig {
 		JournalService:      true,
 		SchedulerService:    true,
 		DynDns:              true,
+		InventoryService:    true,
 
 		// Run the notebook service on the minion so it can run
 		// notebook jobs remotely.