Two small fix #17
Open
Two small fix #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VedantParanjape
requested changes
Jun 21, 2024
| REQUIRES esp_wifi protocol_examples_common nvs_flash esp_websocket_client ) |
There was a problem hiding this comment.
remove the whitespace at the end of the line
| #endif |
There was a problem hiding this comment.
don't remove the empty last line
| } |
There was a problem hiding this comment.
same don't remove the last line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ninja: build stopped: subcommand failed. Compilation failed because tcp_handler.h (in "wifi_logger" component) includes esp_wifi.h, provided by esp_wifi component(s). However, esp_wifi component(s) is not in the requirements list of "wifi_logger". To fix this, add esp_wifi to REQUIRES list of idf_component_register call in /work/espidf/pump/components/wifi_logger/CMakeLists.txt./work/espidf/pump/components/wifi_logger/include/utils.h:10:38: error: 'uint' was not declared in this scope; did you mean 'int'? 10 | char* generate_log_message_timestamp(uint log_level, uint32_t timestamp, char* log_message);