Fix a CVulkanCmdBuffer leak that could result in screenshot request f… #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailures CVulkanDevice::resetCmdBuffers expects m_pendingCmdBufs to be sorted. Using an unordered_map can result in cases where we eagerly exit out of the loop without fully cleaning all the relevant resources. This will result in leaking the command buffer and any resources it transitively references. This can be a problem for screenshots as there are only two screenshot image slots available. If we leak references to these images, at some point we won't be able to allocate new images for screenshot capture and the operation will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ailures
CVulkanDevice::resetCmdBuffers expects m_pendingCmdBufs to be sorted. Using an unordered_map can result in cases where we eagerly exit out of the loop without fully cleaning all the relevant resources. This will result in leaking the command buffer and any resources it transitively references.
This can be a problem for screenshots as there are only two screenshot image slots available. If we leak references to these images, at some point we won't be able to allocate new images for screenshot capture and the operation will fail.