Saving fixed #4

GitHub Actions / Qodana Community for JVM completed Jan 23, 2024 in 0s

22 new problems found by Qodana Community for JVM

Qodana Community for JVM

22 new problems were found

Inspection name	Severity	Problems
`Constant values`	🔶 Warning	2
`Nullability and data flow problems`	🔶 Warning	2
`Confusing 'main()' method`	🔶 Warning	1
`Control flow with empty body`	🔶 Warning	1
`Private data class constructor is exposed via the 'copy' method`	🔶 Warning	1
`Kotlin library and Gradle plugin versions are different`	🔶 Warning	1
`Mismatched query and update of collection`	🔶 Warning	1
`Function or property has platform type`	◽️ Notice	11
`Package name does not match containing directory`	◽️ Notice	2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 14 in minecraft/common/src/main/java/com/ewoudje/lasagna/mixin/MixinMain.java

github-actions / Qodana Community for JVM

Confusing 'main()' method

Method `main()` does not have signature 'public static void main(String\[\])'

Check warning on line 27 in minecraft/forge/src/main/java/com/ewoudje/lasagna/forge/mixin/MixinDimensionSpecialEffects.java

github-actions / Qodana Community for JVM

Constant values

Condition `(Object) entry.getValue() == this` is always `false`

Check warning on line 27 in minecraft/forge/src/main/java/com/ewoudje/lasagna/forge/mixin/MixinDimensionSpecialEffects.java

github-actions / Qodana Community for JVM

Constant values

Result of `EFFECTS.entrySet().stream().filter((entry) -> (Object) entry.getValue() == this) .fi...` is always 'null'

Check warning on line 25 in minecraft/common/src/main/kotlin/com/ewoudje/lasagna/chunkstorage/DeltaNetworkedSectionStorage.kt

github-actions / Qodana Community for JVM

Control flow with empty body

'for' has empty body

Check warning on line 107 in minecraft/common/src/main/kotlin/com/ewoudje/lasagna/networking/LasagnaNetworking.kt

github-actions / Qodana Community for JVM

Private data class constructor is exposed via the 'copy' method

Private primary constructor is exposed via the generated 'copy()' method of a 'data' class.

Check warning on line 118 in minecraft/fabric/src/main/java/com/ewoudje/lasagna/fabric/services/LasagnaPlatformHelperFabric.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Argument `id` might be null

Check warning on line 21 in minecraft/forge/src/main/java/com/ewoudje/lasagna/forge/mixin/MixinDimensionSpecialEffects.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Casting `(Object)this` to `DimensionSpecialEffects` will produce `ClassCastException` for any non-null value

Check warning on line 15 in minecraft/common/build.gradle

github-actions / Qodana Community for JVM

Kotlin library and Gradle plugin versions are different

Plugin version (1.8.21) is not the same as library version (1.9.0)

Check notice on line 14 in minecraft/common/src/main/kotlin/com/ewoudje/lasagna/render/RenderTypes.kt