Prevent shading of commons-lang3 #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commons-lang3 is always provided at runtime, don't shade it to prevent incompatibilities. Closes ValkyrienSkies#617, ValkyrienSkies#616
|
|
|
A bit late since i kinda wanted to include this fix in #800 but it seems thats not happening soon so merging it!! |
|
And ofc thanks for ur contribution |
1 task
1 task
1 task
|
is this likely to be released soon? it causes crashes when alongside a lot of mods |
|
@NthPortal A proper full release isn't going to happen for a long time, since VS2 is still mid vs-api update. You could try merging this into the backport branch though |
|
@PriestOfFerns what backport branch? |
|
Can't a VS maintainer make a release themselves? Why do fixes like this have to be blocked by an API update? |
|
Anyone is welcome to compile this fix into the beta.5 or beta.5 with fixes tag. |
NthPortal
added a commit
to NthPortal/Valkyrien-Skies-2
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't found anything regarding contribution guidelines so I hope this is fine 😄
commons-lang3 is always provided at runtime,
don't shade it to prevent incompatibilities.
Closes #617, #616