Use seated pos when checking entity distance #1021
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE, REASON
Entity::getEyePosition
without partial tick uses VS2 modification as wellIForgePlayer::canReach
, which usesEntity::getEyePosition()
, which is not mixin'ed by VS2 (onlyEntity::getEyePosition(F)
is)KNOWN EFFECTS
CAVEATS
NOT TESTED ON FABRIC
no guarantees when player is not seatedSee: Improved Dragging & Entity Interactions on Ships [Pathfinding, POIs, Raids, etc.] #1027