Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use seated pos when checking entity distance #1021

Conversation

Endalion
Copy link
Contributor

@Endalion Endalion commented Dec 13, 2024

CHANGE, REASON

  • Use the seat position where valid in entity distance checks
    • Utilise the seat position in ship for distance checks which is guaranteed to be accurate for checks on the same ship
  • Entity::getEyePosition without partial tick uses VS2 modification as well
    • pick does not use entity distance checks instead it uses IForgePlayer::canReach, which uses Entity::getEyePosition(), which is not mixin'ed by VS2 (only Entity::getEyePosition(F) is)

KNOWN EFFECTS

  • Interacting with a moving ship while seated on it is significantly more reliable, up to 1km/s (tested)

CAVEATS

NOT TESTED ON FABRIC

@ThePlasticPotato
Copy link
Contributor

Merged into #1027 as of commit b84d58a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants