Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gf command to handle parent directory references #9452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekinakkaya
Copy link

What this PR does / why we need it
This PR fixes the gf command, ensuring it properly resolves parent directory (../) references. Previously, gf failed to navigate to files outside the current directory.

Which issue(s) this PR fixes
Fixes #9439

Special notes for your reviewer

  • I could not add test cases since the build-test command does not work for me. Here is the output of build-test. Maybe it is an issue that occurs on my machine:
PS C:\Users\ekin_\projeler\Vim> npm run build-test

> [email protected] build-test
> gulp prepare-test

[15:15:01] Using gulpfile ~\projeler\Vim\gulpfile.js
[15:15:01] Starting 'prepare-test'...
[15:15:01] Starting 'tsc'...
[15:15:01] Starting 'copyPackageJson'...
C:/Users/ekin_/projeler/Vim/node_modules/@types/glob/index.d.ts(29,42): error TS2694: Namespace '"C:/Users/ekin_/projeler/Vim/node_modules/minimatch/dist/commonjs/index"' has no exported member 'IOptions'.
C:/Users/ekin_/projeler/Vim/node_modules/@types/glob/index.d.ts(75,30): error TS2724: '"C:/Users/ekin_/projeler/Vim/node_modules/minimatch/dist/commonjs/index"' has no exported member named 'IMinimatch'. Did you mean 'Minimatch'?
TypeScript: 2 semantic errors
TypeScript: emit failed
[15:15:10] The following tasks did not complete: prepare-test, tsc, copyPackageJson
Did you forget to signal async completion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The gf command fails to navigate to files with parent directory references
1 participant