-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: replace_phoneme_length()
の見通し改善
#909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
すみません、「推定する」は統計に馴染みがない人だと「推理する」に勘違いされると思うので、意識して使用するのをやめたほうがいいかなと思いました・・・!
詳しくコメントしてみました #909
コンフリクト解消をちょっと間違えてしまいました 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
replace_phoneme_length()
の関数ネスト廃止等によるリファクタリング昨今のリファクタリングにより、
tts_engine.py
の各関数が簡素化した。その結果、現在の
replace_phoneme_length()
内で call されている関数をバラしても(ネストを廃止しても)簡潔なコードが得られるようになった。またネストの廃止により処理の配置が最適化でき、実行高速化や見通し改善が可能になっている。
よって本 PR では、
replace_phoneme_length()
の関数ネスト廃止等によるリファクタリングを提案します。Reviewer 向け情報
変更内容
バラされた(ネストが廃止された)関数は以下の2つ:
pre_process()
split_mora()
:(副次効果: 不要コード実行の削減による高速化)その他、変数名の簡潔化やコード表現簡潔化によるリファクタリングを本 PR は含む。
関連 Issue
part of #792