ENH: Windowsでエンジンの多重起動を可能にする #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabonerune
commented
Jan 15, 2025
| _FILE_SHARE_READ = 0x00000001 | ||
| _OPEN_EXISTING = 3 | ||
| _FILE_FLAG_DELETE_ON_CLOSE = 0x04000000 | ||
| _INVALID_HANDLE_VALUE = HANDLE(-1).value |
There was a problem hiding this comment.
INVALID_HANDLE_VALUEの値がMicrosoftのドキュメントのどこにも書いてありませんでした。
Win32のhandleapi.hの内容を直接確認したところ#define INVALID_HANDLE_VALUE ((HANDLE)(LONG_PTR)-1)となっていたのでこのようにしておきました。
Hiroshiba
reviewed
Jan 15, 2025
|
1bd3d55 でちょっと変更させていただきました！ あとは↓が解決すればマージできそう！ |
sabonerune
commented
Jan 15, 2025
Hiroshiba
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
コンパイル済み辞書を起動しているエンジンのプロセスごとに割り当てることでエンジンの多重起動ができるようにします。
コンパイル済み辞書のファイル名を常にランダムにすることで実現します。
POSIXではopenjtalkが辞書を開いた後にunlinkすることで辞書が残ってしまうことを防ぎます。
WIndowsでは
CreateFileWでFILE_FLAG_DELETE_ON_CLOSEを付けて開いた後すぐに閉じることでファイルが閉じた時に自動的に削除されます。関連 Issue
FILE_FLAG_DELETE_ON_CLOSEを付けて開かれている辞書を扱えるようにする pyopenjtalk#21その他
これまでの議論 #1347 (comment)