Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ソング:ピッチ更新APIを追加 #1513

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

sigprogramming
Copy link
Contributor

内容

ピッチ更新APIを追加します。

関連 Issue

close #1511

その他

@sigprogramming sigprogramming requested a review from a team as a code owner December 31, 2024 02:57
@sigprogramming sigprogramming requested review from Hiroshiba and removed request for a team December 31, 2024 02:57
@Hiroshiba Hiroshiba requested a review from tarepan January 2, 2025 02:20
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

テストの実装もありがとうございます!

ドキュメントとコメントですが、sing系では今のところf0のことを基本周波数と案内してそうだったので、そちらに合わせたいと思います 🙏
勝手ながらコミットさせていただきます!

@Hiroshiba
Copy link
Member

たぶん大丈夫だと思うのでマージします!!
しばらくすると0.23.0-devreleaseが新しくビルドされたエンジンのものに置き換わるはず・・・!

@Hiroshiba Hiroshiba merged commit 1db9ede into VOICEVOX:master Jan 2, 2025
4 checks passed
@sigprogramming sigprogramming deleted the add_sing_frame_f0 branch January 2, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ソング:ピッチ更新APIを追加する
2 participants