Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WriteBarIcon): fix box-shadow color #8227

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(WriteBarIcon): fix box-shadow color #8227

merged 1 commit into from
Feb 3, 2025
+17 −17

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Feb 3, 2025 •
edited
Loading

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

В PRе выше не учли цвет (box-shadow) у каунтера иконки

Release notes

Исправления

  • WriteBarIcon: исправили фоновый цвет count

@BlackySoul BlackySoul added this to the v7.2.0 milestone Feb 3, 2025
@BlackySoul BlackySoul self-assigned this Feb 3, 2025
@BlackySoul BlackySoul requested a review from a team as a code owner February 3, 2025 11:03
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 3, 2025
SevereCloud
SevereCloud previously approved these changes Feb 3, 2025
View reviewed changes
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 3, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 394.45 KB (0%)
JS (gzip) 119.55 KB (0%)
JS (brotli) 98.37 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 347.37 KB (+0.01% 🔺)
CSS (gzip) 42.99 KB (0%)
CSS (brotli) 34.26 KB (-0.1% 🔽)

qurle
qurle previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Позвольте сказать вам огромное человеческое спасибо и выразить мою бесконечную благодарность за вашу неиссякаемую доброту. Я безгранично признателен и благодарен за ваше участие и заботу. Спасибо вам большое, спасибо огромное, спасибо безмерное за вашу неоценимую помощь и поддержку!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

e2e tests

Playwright Report

@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (b44e6e7) to head (814392e).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8227   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         404      404           
  Lines       11531    11531           
  Branches     3830     3830           
=======================================
  Hits        11014    11014           
  Misses        517      517
Flag Coverage Δ
unittests 95.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul force-pushed the blackysoul/fix_writebar_icon branch from 86064bc to 814392e Compare February 3, 2025 11:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

👀 Docs deployed

Commit 814392e

qurle
qurle approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ещё раз спасибо

@BlackySoul BlackySoul removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 3, 2025
@BlackySoul BlackySoul merged commit d0fb8bd into master Feb 3, 2025
29 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_writebar_icon branch February 3, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@qurle qurle qurle approved these changes

@SevereCloud SevereCloud Awaiting requested review from SevereCloud

Assignees

@BlackySoul BlackySoul

Labels
None yet
Projects
VKUI
Archived in project
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BlackySoul @SevereCloud @qurle @andrey-medvedev-vk