Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link previews to permalinks #103

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Add link previews to permalinks #103

merged 3 commits into from
Sep 16, 2024

Conversation

shrey150
Copy link
Contributor

@shrey150 shrey150 commented Sep 15, 2024

Redirects for permalinks now generate link previews based on Open Graph standards.

Known issue: Notion links don't work well (just shows Notion). Will have to investigate more

Copy the following links into Slack or iMessage to test!

image

Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for v1-platform ready!

Name Link
🔨 Latest commit c67eda0
🔍 Latest deploy log https://app.netlify.com/sites/v1-platform/deploys/66e6b5fd78b1a90008253993
😎 Deploy Preview https://deploy-preview-103--v1-platform.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shrey150 shrey150 changed the title test link previews Add link previews to permalinks Sep 15, 2024
@shrey150 shrey150 marked this pull request as ready for review September 15, 2024 10:41
Copy link
Contributor

@iyasinn iyasinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@iyasinn iyasinn merged commit d0eb0e9 into master Sep 16, 2024
5 of 9 checks passed
@iyasinn iyasinn deleted the sp/add-rich-link-previews branch September 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants