Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Development #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac54402
notification
V-KMilev Mar 13, 2021
0517a54
rework development pull
V-KMilev Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/com/appnull/commands/impls/GetCodesCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

public class GetCodesCommand implements CommandHandler {

private final static String img = "https://cdn.discordapp.com/attachments/718871472336273429/806569636169515052/11.png";
private final static String img = "https://cdn.discordapp.com/attachments/710039794884935743/820371562019815474/unknown.png";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This String img is the same in many files, make some class called BotStaticResources and put all such things there like public static final strings


private final Properties prop = new Properties();
private final String propFileTime = "time.properties";
Expand Down
4 changes: 2 additions & 2 deletions src/com/appnull/notifications/Notify.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

public class Notify extends TimerTask {

private final static String img = "https://cdn.discordapp.com/attachments/718871472336273429/806569636169515052/11.png";
private final static String img = "https://cdn.discordapp.com/attachments/710039794884935743/820371562019815474/unknown.png";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the above comment

private final String startTime;

private GuildMessageReceivedEvent event;
Expand All @@ -38,7 +38,7 @@ private void messageBase() {

EmbedBuilder eb = new EmbedBuilder();

eb.setTitle("Notification about a subject!");
eb.setTitle("Notification");

eb.addField("Subject: " + subject.getName(), "`Positon of the Subject:` **" + subject.getPosition()
+ "**\n**`Code:`** ||**" + subject.getCode() + "**||", true);
Expand Down
8 changes: 4 additions & 4 deletions src/com/appnull/schedule/Schedule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package com.appnull.schedule;

import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.IOException;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.FileNotFoundException;

import java.util.Map;
Expand All @@ -21,12 +21,12 @@
import java.text.ParseException;
import java.text.SimpleDateFormat;

import org.apache.commons.collections4.map.HashedMap;

import com.appnull.subject.Subject;
import com.appnull.subject.SubjectImpl;
import com.appnull.notifications.Notify;

import org.apache.commons.collections4.map.HashedMap;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added imports seem unused


import net.dv8tion.jda.api.events.message.guild.GuildMessageReceivedEvent;

public class Schedule {
Expand Down