-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Northern Ireland #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
reviewed
May 31, 2024
penelopeysm
reviewed
May 31, 2024
Co-authored-by: Penelope Yong <[email protected]>
sgreenbury
commented
Jun 6, 2024
Co-authored-by: Penelope Yong <[email protected]>
Having methods to add and remove partition keys simplifies the Country API for subclassing. Co-authored-by: Penelope Yong <[email protected]>
Co-authored-by: Penelope Yong <[email protected]>
sgreenbury
commented
Jun 6, 2024
This is to ensure that only partitions from the latest materialization are included. Co-authored-by: Penelope Yong <[email protected]>
Co-authored-by: Penelope Yong <[email protected]>
Co-authored-by: Penelope Yong <[email protected]>
This was referenced Jun 7, 2024
Thanks @penelopeysm, merging this now. |
This was referenced Jun 19, 2024
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #36.
This PR ports previous Rust implementation of NI to Dagster. To summarise:
Currently only partially uses the aCountry
base class approach Generalise country specific code using abstract base class #84, we can either refactor the assets to implement a more a complete base class format or remove during this PRRemaining tasks
ENV=prod
to include all ready-made tables (where possible)