Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Northern Ireland #98

Merged
merged 42 commits into from
Jun 7, 2024
Merged

Port Northern Ireland #98

merged 42 commits into from
Jun 7, 2024

Conversation

sgreenbury
Copy link
Collaborator

@sgreenbury sgreenbury commented May 22, 2024

Contributes towards #36.

This PR ports previous Rust implementation of NI to Dagster. To summarise:

Remaining tasks

  • Update derived metrics to generate columns programmatically from a pivot
  • Update ENV=prod to include all ready-made tables (where possible)
  • Fix the issue where automatically constructed hxltags have additional "_"
  • Ensure pivoted metric tables are integers not floats

@sgreenbury sgreenbury marked this pull request as ready for review May 23, 2024 11:18
@sgreenbury sgreenbury mentioned this pull request May 23, 2024
9 tasks
pyproject.toml Show resolved Hide resolved
python/popgetter/__init__.py Outdated Show resolved Hide resolved
python/popgetter/assets/ni/__init__.py Outdated Show resolved Hide resolved
python/popgetter/assets/ni/__init__.py Outdated Show resolved Hide resolved
python/popgetter/assets/country.py Outdated Show resolved Hide resolved
python/popgetter/assets/country.py Show resolved Hide resolved
python/popgetter/assets/ni/__init__.py Outdated Show resolved Hide resolved
python/popgetter/assets/ni/__init__.py Outdated Show resolved Hide resolved
python/popgetter/assets/country.py Show resolved Hide resolved
python/popgetter/assets/ni/__init__.py Show resolved Hide resolved
sgreenbury and others added 4 commits June 6, 2024 16:43
Co-authored-by: Penelope Yong <[email protected]>
Having methods to add and remove partition keys simplifies the Country API for subclassing.

Co-authored-by: Penelope Yong <[email protected]>
Co-authored-by: Penelope Yong <[email protected]>
notebooks/explore.ipynb Outdated Show resolved Hide resolved
@sgreenbury
Copy link
Collaborator Author

Thanks @penelopeysm, merging this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done:
Development

Successfully merging this pull request may close these issues.

2 participants