-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add devcontainer file and define path for utils.py #76
base: main
Are you sure you want to change the base?
add devcontainer file and define path for utils.py #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Cc @dabreegster
.devcontainer/postCreateCommand.sh
Outdated
# Ensure cargo command is available | ||
command -v cargo | ||
|
||
# Install odjitter using cargo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we doing anything with odjitter at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably from a different container definition that was copied-across.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have removed it from postCreateCommand.sh
import csv | ||
import json | ||
|
||
from utils import * | ||
# Add the parent directory to the system path | ||
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be symlinks for all the examples to make utils.py
work. Is it not working in the devcontainer for some reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ye, this "../utils.py" not working in the devcontainer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment explaining this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some changes, please confirm they're all fine, and then I'll merge. Thanks for the PR!
import csv | ||
import json | ||
|
||
from utils import * | ||
# Add the parent directory to the system path | ||
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment explaining this
.devcontainer/postCreateCommand.sh
Outdated
sudo make install | ||
tippecanoe --version | ||
|
||
# Add local instance of odjitter to the /usr/local/bin directory: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this part, I removed it
No description provided.