Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process attchments in partitioning nested emails (#3604) #3605

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

S1M0N38
Copy link

@S1M0N38 S1M0N38 commented Sep 7, 2024

No description provided.

- Added `attachment_partitioner` parameter to `partition_msg` function.
- Updated `MsgPartitionerOptions` class to include
`attachment_partitioner` attribute.
- Modified `_AttachmentPartitioner` class to use the custom
`attachment_partitioner` if provided.
@tc360950
Copy link
Contributor

tc360950 commented Sep 28, 2024

@S1M0N38 Will this not break existing code of the users? Shouldn't attachment_partitioner be optional?

@S1M0N38
Copy link
Author

S1M0N38 commented Sep 28, 2024

#3671 attachment_partitioner is no more a valid param of partion_msg. This PR is outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants