Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to @sentry/nextjs (removing @sentry/browser and @sentry/node) #370

Draft
wants to merge 39 commits into
base: v2-mst-aptd-at-lcz-sty
Choose a base branch
from
Draft

Migrating to @sentry/nextjs (removing @sentry/browser and @sentry/node) #370

wants to merge 39 commits into from

Commits on Jun 10, 2021

  1. Configure @sentry/next using "npx @sentry/wizard -i nextjs" + removed… 

    … auth.token from sentry.properties to avoid leaking sensitive token (need to find a way to configure it securely, probably through env var)
    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    f86c19f View commit details
    Browse the repository at this point in the history

  2. Misc

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    5d526cf View commit details
    Browse the repository at this point in the history

  3. Use @sentry/nextjs instead of @sentry/node

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    0cd0cd7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'v2-mst-aptd-at-lcz-sty' into next-sentry

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    42f1d48 View commit details
    Browse the repository at this point in the history

  5. Remove log

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    0d5baee View commit details
    Browse the repository at this point in the history

  6. Add example showing the Sentry report dialog

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    105afbd View commit details
    Browse the repository at this point in the history

  7. Reorder env vars

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    8389f3a View commit details
    Browse the repository at this point in the history

  8. Add NEXT_PUBLIC_SENTRY_DSN

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    17db210 View commit details
    Browse the repository at this point in the history

  9. Move withSentryConfig webpack plugin AFTER withNextPluginPreval, othe… 

    …rwise it makes a MESS and all env vars are undefined!
    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    814c6b1 View commit details
    Browse the repository at this point in the history

  10. Remove log

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    0018b80 View commit details
    Browse the repository at this point in the history

  11. Adapt doc for other people not to fall in the same trap

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    7a35307 View commit details
    Browse the repository at this point in the history

  12. Improve interactive error demo + fix TS errors

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    be57969 View commit details
    Browse the repository at this point in the history

  13. Add vercel secret nrn-sentry-auth-token

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    1 Configuration menu
    Copy the full SHA
    5c82a99 View commit details
    Browse the repository at this point in the history

  14. Use withSentry HOC for error, too

    @Vadorequest
    Vadorequest committed Jun 10, 2021
    1 Configuration menu
    Copy the full SHA
    8cc7c3a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Enable debug mode

    @Vadorequest
    Vadorequest committed Jun 14, 2021
    1 Configuration menu
    Copy the full SHA
    0940f3c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Merge branch 'v2-mst-aptd-at-lcz-sty' into next-sentry 

    # Conflicts:
#	src/modules/core/amplitude/amplitude.ts
#	src/modules/core/sentry/sentry.ts
#	src/pages/_error.tsx
#	src/pages/api/error.ts
#	src/pages/api/status.ts
#	yarn.lock
    @Vadorequest
    Vadorequest committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    0a2fd8e View commit details
    Browse the repository at this point in the history

  2. Fix issues

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    1 Configuration menu
    Copy the full SHA
    c3d1553 View commit details
    Browse the repository at this point in the history

  3. Import sentry from @sentry/nextjs

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    002c54e View commit details
    Browse the repository at this point in the history

  4. Log full error

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    1 Configuration menu
    Copy the full SHA
    dc67f66 View commit details
    Browse the repository at this point in the history

  5. Attempt try/catch flushing

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    1 Configuration menu
    Copy the full SHA
    84e4574 View commit details
    Browse the repository at this point in the history

  6. Use withSentry for all API endpoints + remove try/catch

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    1 Configuration menu
    Copy the full SHA
    fbc7002 View commit details
    Browse the repository at this point in the history

  7. Refacto

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    1d01078 View commit details
    Browse the repository at this point in the history

  8. Add tracesSampleRate

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    1 Configuration menu
    Copy the full SHA
    12bfda6 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'v2-mst-aptd-at-lcz-sty' into next-sentry 

    # Conflicts:
#	src/pages/_error.tsx
#	src/pages/api/error.ts
#	src/pages/api/preview.ts
#	src/pages/api/status.ts
#	src/pages/api/webhooks/deploymentCompleted.ts
    @Vadorequest
    Vadorequest committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    1c2a56e View commit details
    Browse the repository at this point in the history

  10. Merge branch 'v2-mst-aptd-at-lcz-sty' into next-sentry 

    # Conflicts:
#	src/layouts/core/components/CoreLayout.tsx
#	src/layouts/demo/components/DemoLayout.tsx
#	src/layouts/quickPreview/components/QuickPreviewLayout.tsx
#	src/modules/core/sentry/init.ts
#	src/pages/api/startVercelDeployment.ts
    @Vadorequest
    Vadorequest committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    edd621f View commit details
    Browse the repository at this point in the history

  11. Use '@sentry/nextjs' instead of @sentry/node'

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    1 Configuration menu
    Copy the full SHA
    204d53f View commit details
    Browse the repository at this point in the history

  12. Merge branch 'v2-mst-aptd-at-lcz-sty' into next-sentry 

    # Conflicts:
#	src/modules/core/githubActions/dispatchWorkflow.ts
#	src/modules/core/githubActions/dispatchWorkflowByPath.ts
    @Vadorequest
    Vadorequest committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    abfe455 View commit details
    Browse the repository at this point in the history

  13. Add more doc + make Sentry silent

    @Vadorequest
    Vadorequest committed Jun 24, 2021
    1 Configuration menu
    Copy the full SHA
    599f5ed View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Merge branch 'v2-mst-aptd-at-lcz-sty' into next-sentry 

    # Conflicts:
#	package.json
#	src/modules/core/sentry/init.ts
#	src/modules/core/sentry/server.ts
#	src/pages/api/startVercelDeployment.ts
#	yarn.lock
    @Vadorequest
    Vadorequest committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f70a44d View commit details
    Browse the repository at this point in the history

  2. Avoid duplicating config between browser/server

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    5ba6c1b View commit details
    Browse the repository at this point in the history

  3. Use NEXT_PUBLIC_SENTRY_DSN + add test

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f9571d8 View commit details
    Browse the repository at this point in the history

  4. Wrap all API endpoint with Sentry.withSentry

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    1 Configuration menu
    Copy the full SHA
    d285b72 View commit details
    Browse the repository at this point in the history

  5. Test Vercel ENV (unrelated)

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    dbe2325 View commit details
    Browse the repository at this point in the history

  6. Test Vercel ENV (unrelated)

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    1 Configuration menu
    Copy the full SHA
    6e4b9b4 View commit details
    Browse the repository at this point in the history

  7. Avoids capturing false-positive 404 pages when building the 404 page

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    1 Configuration menu
    Copy the full SHA
    fbd279f View commit details
    Browse the repository at this point in the history

  8. Use build-env

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    8fdc4ce View commit details
    Browse the repository at this point in the history

  9. Fix debug mode

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    3df2809 View commit details
    Browse the repository at this point in the history

  10. Reset deploy env vars

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    1 Configuration menu
    Copy the full SHA
    c0f84e2 View commit details
    Browse the repository at this point in the history

  11. Use dryRun in development mode

    @Vadorequest
    Vadorequest committed Jun 25, 2021
    1 Configuration menu
    Copy the full SHA
    f681da0 View commit details
    Browse the repository at this point in the history