Random Terrain Tile #283
Random Terrain Tile #283
Conversation
|
|
| } | ||
|
|
||
| private Sprite[][] GetSpritesAsOne() { | ||
| Sprite[][] m_Sprites = new Sprite[15][]; |
There was a problem hiding this comment.
It looks like this could be a switch statement returning the correct Sprite Array when the index is passed it. This would avoid creating a new array of arrays each time.
| return (tile != null && tile == this); | ||
| } | ||
|
|
||
| private int GetIndex(byte mask) |
There was a problem hiding this comment.
This and GetTransform below is used by the original Terrain Tile itself. Perhaps we could consider making RandomTerrainTile inherit from TerrainTile and try to share as much common functions as possible?
| @@ -0,0 +1,33 @@ | |||
| # Random Terrain Tile | |||
|
|
|||
There was a problem hiding this comment.
Thanks for writing the documentation for this!
A small addition would be adding a contribution note with your username too, for example in https://github.com/Unity-Technologies/2d-extras/blob/master/Documentation~/LineBrush.md . It would be good acknowledgement of your work here!
| // } | ||
|
|
||
|
|
||
| // public override void OnInspectorGUI() |
There was a problem hiding this comment.
Having a nice inspector would be great if possible!
|
hi @ChuanXin-Unity , thank you for the feedback! I'm going to do those corrections soon. Have a nice week! |
|
hi @ChuanXin-Unity , I have a question, though: as this repository is no longer maintained, as it's mentioned in README.md, what happens to these PRs? I mean, my plan is to update this branch to latest version of thank you in advance |
|
The notice in the README.md is based of the latest directive from our superiors, and they are still currently in discussions on what to do with this on the whole. Unfortunately, there is nothing concrete yet, other than it is possible that this repository could be made internal. For now, you can continue working by updating the branch to the latest version of master and updating the PR as well, we will still continue to take and look at the PR and accept it to the repository. Thanks! |
I have made this new tile system, which is a copy of Terrain Tile, but with random behaviour for all given levels. It also includes a schema that facilitates how to draw a layout and position tiles in the expected rotation.
This one is based on version 1.5.0-preview, as it's the one that worked for my version of Unity.
I'd like you to appreciate this pull request. If I get positive feedback, I can update it to the latest version on master branch, and add more documentation and tests, if necessary/possible.