Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESlint + Husky #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ESlint + Husky #1

wants to merge 5 commits into from

Conversation

Claytonrss
Copy link
Member

@Claytonrss Claytonrss commented Feb 12, 2023 •
edited
Loading

O que foi feito?

  • ESlint - Adicionado e configurado
  • Husky - Adicionado e configurado
  • Refatoração de algumas importações para ficar padronizado
  • Aplicado Estilo de código definido no Eslint

milealmeida
milealmeida reviewed Feb 12, 2023
View reviewed changes
src/socket.ts

const CLIENT_DOMAIN = process.env.CLIENT_DOMAIN;
export function startServer(server: any) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não da para fazer algo assim, para tirar esse any??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milealmeida milealmeida milealmeida left review comments

@BrunoNunes96 BrunoNunes96 Awaiting requested review from BrunoNunes96

@ander0308 ander0308 Awaiting requested review from ander0308

@iamdevmarcos iamdevmarcos Awaiting requested review from iamdevmarcos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Claytonrss @milealmeida