Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing-api): support routing on unichain mainnet #919

Merged
merged 14 commits into from
Jan 23, 2025

Conversation

xrsv
Copy link
Contributor

@xrsv xrsv commented Nov 21, 2024

Support routing in Routing API for Unichain Mainnet.

Pending

Testing

  • Validated with DAI/ETH V2 pool quote
  • V3 gives no_route with very low DAI liquidity, but we'll go ahead to unblock FE for now
image

@xrsv xrsv requested review from jsy1218 and cgkol November 21, 2024 21:19
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per the other pr, is there a screenshot where it showcases that the apis work as expected?

test/mocha/e2e/quote.test.ts Outdated Show resolved Hide resolved
Copy link

socket-security bot commented Jan 23, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@uniswap/[email protected] 🔁 npm/@uniswap/[email protected] Transitive: environment, eval, filesystem, network, shell +100 116 MB

View full report↗︎

@graphite-app graphite-app bot requested review from a team and cgkol January 23, 2025 17:14
Copy link

graphite-app bot commented Jan 23, 2025

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (01/23/25)

1 assignee was added and 3 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation.

@xrsv
Copy link
Contributor Author

xrsv commented Jan 23, 2025

per the other pr, is there a screenshot where it showcases that the apis work as expected?

added test details in description

@xrsv xrsv merged commit ef6173c into main Jan 23, 2025
7 checks passed
@xrsv xrsv deleted the xrsv/routing-api-unichain branch January 23, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants