upgrade to docusaurus v3 #826
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smblee is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Report is too large to display inline. Next stepsMark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
saucepoint
reviewed
Dec 5, 2024
| @@ -118,7 +118,7 @@ function getSqrtPriceAtTick(int24 tick) internal pure returns (uint160 sqrtPrice | |||
|
|
|||
| ### getTickAtSqrtPrice | |||
|
|
|||
| Calculates the greatest tick value such that getSqrtPriceAtTick(tick) <= sqrtPriceX96 | |||
| Calculates the greatest tick value such that getSqrtPriceAtTick(tick) \<= sqrtPriceX96 | |||
There was a problem hiding this comment.
flagging for myself -- the markdown files in v4/reference/* are generated with forge doc and copied to this repo's directory structure in uniswap/docs/scripts/v4-forge-doc.sh
I'll update the script and use sed to make sure we're escaping docusaurus v3 special characters
this shouldnt block our upgrade to docusaurus v3 tho
|
Report too large to display inline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.