Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add price impact events #83

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jperler
Copy link
Contributor

@jperler jperler commented Sep 23, 2024

Background

WEB-4928

Add tracking around swap price impact acknowledgement

Changes

  • Adds SWAP_PRICE_IMPACT_ACKNOWLEDGED

Before merging, please ensure the following:

  • All events have been approved by both product and engineering
  • All events have been tested in their consuming package
  • This PR is titled as feat for any new events, or otherwise follows conventional commit standards

@jperler jperler requested a review from a team as a code owner September 23, 2024 19:10
@jperler jperler force-pushed the 09-23-feat_web_add_price_impact_events branch from 2905a3d to da719a1 Compare September 23, 2024 19:14
@jperler jperler merged commit 93788fe into main Sep 24, 2024
7 checks passed
@jperler jperler deleted the 09-23-feat_web_add_price_impact_events branch September 24, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants