Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lesson codebase #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Improve lesson codebase #2

wants to merge 7 commits into from

Conversation

devvspaces
Copy link

Improvements

  1. Updated dependency versions for dotenv and @solana/web3.js
  2. Remove unused dependency @solana/spl-token
  3. Updated codebase to use esrun eliminating the need for async func main() wrappers
  4. Update the codebase to send a versioned transaction, sending legacy transaction in @solana/web3.js is deprecated

@devvspaces devvspaces mentioned this pull request Sep 12, 2024
Open
mikemaccana
mikemaccana requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but please just import only what you need from web3.js (this is more efficient as it allows tree-shaking).

@mikemaccana mikemaccana mentioned this pull request Sep 24, 2024
Open
@devvspaces
Copy link
Author

@mikemaccana I have done that now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemaccana mikemaccana Awaiting requested review from mikemaccana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devvspaces @mikemaccana