Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymaker Polyflex material correction/update #196

Closed
wants to merge 3 commits into from
Closed

Polymaker Polyflex material correction/update #196

wants to merge 3 commits into from

Conversation

64bittuning
Copy link
Contributor

Polymaker still makes the PolyFlex materials, however they are not a PLA based material, they are TPU.
Please see the following link to their site.

https://us.polymaker.com/search?type=product&options%5Bprefix%5D=last&options%5Bunavailable_products%5D=last&q=polyflex

Polymaker still makes the PolyFlex materials, however they are not a PLA based material, they are TPU.
Please see the following link to their site.

https://us.polymaker.com/search?type=product&options%5Bprefix%5D=last&options%5Bunavailable_products%5D=last&q=polyflex
I found that the "+" in the materials field was causing the materials to not load a profile, even when expressly names in a profile set that I was creating. Simply changing the <material> back to a standard type, and then editing the label seemed to correct the issue.
@64bittuning
Copy link
Contributor Author

64bittuning commented Mar 10, 2022

Additionally, referring to Ultimaker/Cura#11381
I found that the "+" in the materials field was causing the materials to not load a profile, even when expressly names in a profile set that I was creating. Simply changing the back to a standard type, and then editing the label seemed to correct the issue.
image
As you can see in the above screenclip, selecting materials with a non-standard name will cause an error to report, and remove all profile options.

This PR will correct the issue and allow these filaments to be used based off a profile that either attributes to a "generic_" profile, or when called specifically in a "Quality" file that is specific to a machine or machine family.

image

@Ghostkeeper
Copy link
Contributor

Perhaps a better solution, looking to the future, is to change Cura/Uranium such that these are working properly? A lot of people made their own materials too, and those wouldn't be fixed by this change. This change also has the danger that it causes the PLA profiles to be applied to PLA+ materials, which may clash (if a printer has both). They had a different material type for a reason.

@64bittuning
Copy link
Contributor Author

Having the + in the material name, causes a hard fault, and Cura cannot and does not understand it.

I would have posted this as a bug report but that is unfortunately not available here.

Perhaps a release to the fdm_matetials repository with a list of "accepted" materials categories would be a good idea. I believe if you look deeper into this, you might find that the + is the source of the issue and should just be replaced by "plus".

I stand by this PR as I have done a lot of checking with ways to fix it.

@Ghostkeeper
Copy link
Contributor

Yeah, what I was saying is that perhaps this should be fixed from Cura's side, to allow Cura to understand the +.

Changing the + into the word plus would be better as a workaround because it would keep the PLA+ profiles as a separate group of profiles from PLA. Both solutions would require a version upgrade to update the user's existing profiles though. I'd rather fix this from Cura's side instead.

@64bittuning
Copy link
Contributor Author

64bittuning commented Apr 10, 2022

Thank you for the explanation, I understand now.

@64bittuning 64bittuning closed this by deleting the head repository Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants