Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-10149] make 'Lay Flat By Face' work for groups & merges #942

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

rburema
Copy link
Member

@rburema rburema commented Feb 28, 2024

It wouldn't even let you select a face if the selected node was a group or a merged mesh.

Should fix Ultimaker/Cura#14237

Note that when this is the case (group or merged) the object selected for face node isn't the same as the 'overall' selected node in the scene. In that case, the overall object is the parent group or merged node, but the selected object 'for the face' needs to be one with a mesh directly attached to it (so a leaf in that tree).

part of CURA-10149
done as part of CURA-10149
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark, a manifest debug instruction is still present

UM/View/SelectionPass.py Outdated Show resolved Hide resolved
done as part of CURA-10149
@wawanbreton wawanbreton merged commit 1e18559 into main Mar 1, 2024
8 checks passed
@wawanbreton wawanbreton deleted the CURA-10149_select_face_for_groups branch March 1, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Align face to build plate" does not work for grouped or merged models
2 participants