CURA-10967-extention of setpropertyvalue function #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the name was missing it would cause Cura to crash. If the type was missing it wouldn't crash, but it would silently fail to load the model which is also not good. With this change, in both cases it will add a warning to the log. Contributes to issue CURA-3Z4.
CURA-11050
CURA-11050
set property value updated to take into account if resolve is present or not.
CURA-11050
CURA-11050
Applied suggestion from @casperlamboo CURA-11050 Co-authored-by: Casper Lamboo <[email protected]>
fix review comment Co-authored-by: Casper Lamboo <[email protected]>
…for_first_time Cura 11050 switching printers for first time
Don't allow containers without type and name in container registry
set property value updated to take into account if resolve is present or not.
…ue in propertyProvider CURA-10967
…port-material' into CURA-10967_support-type-with-support-material
CURA-10967
CURA-10967
|
This PR is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set property value updated to take into account if resolve is present or not.
To be reviewed with: Ultimaker/Cura#16845