Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mingda printers Definitions #19407

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Add Mingda printers Definitions #19407

wants to merge 25 commits into from

Conversation

HellAholic
Copy link
Contributor

@HellAholic HellAholic commented Jul 20, 2024 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

  • Test A: Add printer flow -> Slice -> generate Gcode
  • Test B: Test print

Test Configuration:

  • Operating System: Win11

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change
  • Update setting version to 24

@HellAholic HellAholic added PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions PR: Community Contribution 👑 Community Contribution PR's labels Jul 20, 2024
@HellAholic HellAholic changed the title Add Definitions Add Mingda printers Definitions Jul 20, 2024
HellAholic and others added 6 commits July 20, 2024 21:51
@HellAholic
update version
df80f44
@HellAholic
Merge branch 'mingda_printers' of https://github.com/Ultimaker/Cura i…
427e4a9 
…nto mingda_printers
@HellAholic
Update mesh stl
793946b 
Reduce the triangle count
@HellAholic
Profile corrections
5ff041f 
Extruder definitions should be per printer rather than in the base printer
@HellAholic @github-actions
Applied printer-linter format
2a8b682
@HellAholic
Revert "Profile corrections"
71054fd 
This reverts commit 5ff041f.
@HellAholic HellAholic mentioned this pull request Jul 21, 2024
Open
github-actions[bot]
github-actions bot requested changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot requested changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)

resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Outdated Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Show resolved Hide resolved
resources/definitions/mingda_base_plus.def.json Show resolved Hide resolved
@HellAholic HellAholic requested review from github-actions[bot] and removed request for github-actions[bot] July 21, 2024 14:03
@HellAholic HellAholic marked this pull request as ready for review July 21, 2024 14:06
@HellAholic HellAholic closed this Jul 21, 2024
@HellAholic HellAholic reopened this Jul 21, 2024
@HellAholic HellAholic removed the request for review from github-actions[bot] July 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

Assignees
No one assigned
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HellAholic