Create command abstraction and split up command builder #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added command and flag definition structures to separate building the command metadata and actually rendering the CLI commands. Moved all the interaction with the cli/v2 module in the cli.go source file which simplifies the interactive with the module and abstracts the details away. The change also moves out some parts from the command_builder which grew in complexity.
thschmitt
requested review from
radu-iviniciu and
florin-szilagyi
as code owners
radu-iviniciu
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added command and flag definition structures to separate building the command metadata and actually rendering the CLI commands.
Moved all the interaction with the cli/v2 module in the
cli.gosource file which simplifies the interactive with the module and abstracts the details away.The change also moves out some parts from the
command_builderwhich grew in complexity.