Latitude & Longitude Interval Cross Section, Updated Bounding Box Subset

[philipc2]

Closes #1104

Overview

• Introduces bounded latitude & longitude cross sections, which returns a new grid with elements strictly between two lines of constant latitude or longitude
• Updates bounding box subset to use the spherical bounds instead of KDTree queries

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[aaronzedwick]

Glad to see this, definitely nice to have this updated. Quick clarification, does this update the bounding box and cross-section to be strictly between those bounds? So if I do a bounding box with a face center as the element, and a face center is inside the bounds but the whole face is not, will it include that face or not?

[aaronzedwick]

Not using KDTree queries will definitely speed things up though, so that is really good.

[philipc2]

Glad to see this, definitely nice to have this updated. Quick clarification, does this update the bounding box and cross-section to be strictly between those bounds? So if I do a bounding box with a face center as the element, and a face center is inside the bounds but the whole face is not, will it include that face or not?

The subset.bounding_box() methods now use the Grid.bounds to accurately determine the bounding box, instead of using an approximate query.

So if I do a bounding box with a face center as the element, and a face center is inside the bounds but the whole face is not, will it include that face or not?

There is no longer an element needed, since we are not using the coordinates for the query, instead we use the actual geometry.

[rajeeja]

good addition, will review more today.

[rajeeja]

looks good, minor comment for tests

[rajeeja]

some comment on what is in quad hex grid and why the lon/lat ranges in test here return the faces as shown in asserts would help the readability of the code.