Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds first organizational member #1594

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

exoticDFT
Copy link
Member

@exoticDFT exoticDFT commented Oct 12, 2024

Creates a section in the organizational membership page to put logos

Description

  • Adds section in organization membership page for logos
  • Creates data file for storing org member information
  • Adds include file for generating org member cards
  • Adds Notre Dame's CRC as organizational member

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

- Adds section in organization membership page for logos
- Creates data file for storing org member information
- Adds include file for generating org member cards
- Adds Notre Dame's CRC as organizational member
@exoticDFT exoticDFT added enhancement New feature or request content labels Oct 12, 2024
@exoticDFT exoticDFT self-assigned this Oct 12, 2024
@sandragesing
Copy link
Contributor

There is a failed test with the job board. I think we can approve the pull request though since it does not touch the job board.

- Updates the image src to reference the baseurl so circleci will render/find the images
@exoticDFT
Copy link
Member Author

The silly circleci wouldn't render the image correctly before. I had to make one more commit to fix that. Here's the final rendered page to view: https://output.circle-artifacts.com/output/job/2856b4fe-ccb9-4410-a36f-8a2208b58514/artifacts/0/usrse.github.io/org-membership/index.html. If you want to just take one more quick look @sandragesing

- Fixes a mistake in capturing the time variable for opening elections
Copy link
Contributor

@sandragesing sandragesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@sandragesing sandragesing merged commit d8f3a36 into USRSE:main Oct 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants