Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Metadata cleanup #12

Merged
merged 9 commits into from
Nov 3, 2020
Merged

Metadata cleanup #12

merged 9 commits into from
Nov 3, 2020

Conversation

limnoliver
Copy link
Member

I did not add min/max for most things, but did run through the xml validation and fixed most errors. There are some publication or creation dates to fill in, and I've reached out to Farshid about these.

Copy link
Member

@aappling-usgs aappling-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving the flow observations?

longitude-res: 0.00001
data-name: Flow and water temperature observations
data-description: >-
Flow and water temperature observations used to train and validate models described in Rahmani et al. 2020.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move flow observations to the Inputs item, too? (we already did this for flow predictions from the Ouyang model)

Copy link
Member Author

@limnoliver limnoliver Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I did not move these. Will do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done!

link: XX
Enhancing streamflow forecast and extracting insights using continental-scale long-short term memory networks with data integration
pubdate: 2020
link: https://doi.org/10.1029/2019WR026793

build-environment: >-
We used XX open source XX; Any supercomputing resources used? XX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, let's plan to (1) get more info from farshid about the compute environment (i added a bullet to "Text chunks we hope Farshid can fill in" in the "ERL data release plan" doc) and (2) add a reference to the environment.yml. I will make an issue for this so I can plan to do it - i have most of the info in hand already but will need a few minutes to put it together.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We could also just write one cover-everything text chunk that we use for all metadata files)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added notes to #7

src/munge_functions.R Show resolved Hide resolved
@aappling-usgs aappling-usgs merged commit 9ac8b43 into USGS-R:main Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants