-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about moving the flow observations?
in_text/text_02_observations.yml
Outdated
longitude-res: 0.00001 | ||
data-name: Flow and water temperature observations | ||
data-description: >- | ||
Flow and water temperature observations used to train and validate models described in Rahmani et al. 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move flow observations to the Inputs item, too? (we already did this for flow predictions from the Ouyang model)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I did not move these. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done!
link: XX | ||
Enhancing streamflow forecast and extracting insights using continental-scale long-short term memory networks with data integration | ||
pubdate: 2020 | ||
link: https://doi.org/10.1029/2019WR026793 | ||
|
||
build-environment: >- | ||
We used XX open source XX; Any supercomputing resources used? XX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one, let's plan to (1) get more info from farshid about the compute environment (i added a bullet to "Text chunks we hope Farshid can fill in" in the "ERL data release plan" doc) and (2) add a reference to the environment.yml. I will make an issue for this so I can plan to do it - i have most of the info in hand already but will need a few minutes to put it together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(We could also just write one cover-everything text chunk that we use for all metadata files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added notes to #7
I did not add min/max for most things, but did run through the xml validation and fixed most errors. There are some publication or creation dates to fill in, and I've reached out to Farshid about these.