Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmanifestSearch class #715

Merged
merged 11 commits into from
May 11, 2024
Merged

EmanifestSearch class #715

merged 11 commits into from
May 11, 2024

Conversation

dpgraham4401
Copy link
Member

Description

This PR adds a new EmanifestSearch class we use for querying the e-Manifest API for manifests (the manifest search endpoint). The e-Manifest team kind of uses this search endpoint as a swiss army blade for finding manifest data.

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@dpgraham4401
EManifest search method refactor to use dict instead of long lists of…
d16aa8c 
… keyword args
@dpgraham4401
fix login for DRF browsable API, add dev fixture for trak user access to
7880139 
Generators Organzation llc.
@dpgraham4401
minor clean up and remove old unit test
6d47287 
thing like removing verbose if-else for more simple implementations
@dpgraham4401
fix button bubbling event and submitting form when save button not re…
b30bad6 
…ndered
@dpgraham4401
EmanifestSearch class - a class for searching using the e-Manifest se…
88aeffb 
…rvices that

exposes a builder API
@dpgraham4401
validate emanifest search user input are values expected by e-Manifes…
3159aec 
…t API
@dpgraham4401
add start, end date, and correction request status to EmanifestSearch…
510ed5e 
… builder api
@dpgraham4401
end_date defaults to datetime.now() (with UTC tzinfo)
d0b177c
@dpgraham4401
emanifest search class execute requests a search from rcrainfo
ba382cf
@dpgraham4401
add mock_emanifest_auth_responses, test builds the search
41407ae
@dpgraham4401
repalce manifest service search usage with EmanifestSearch class usage
eb9aa24
@github-actions github-actions bot added client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included labels May 11, 2024
@dpgraham4401 dpgraham4401 merged commit 37d0428 into USEPA:main May 11, 2024
11 checks passed
@dpgraham4401 dpgraham4401 deleted the manifest_search_refactor branch May 11, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
No open projects
Haztrak
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgraham4401