Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create e manifest #581

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Create e manifest #581

merged 7 commits into from
Aug 28, 2023

Conversation

dpgraham4401
Copy link
Member

Description

This PR adds a service (for our frontend) for creating electronic manifest through the RCRAInfo manifest save service.

what that includes

  1. URL routing
  2. CreateRcraManifestView
  3. a create_rcra_manifest celery task to offload the process from the HTTP lifecycle (between our front end and backend)
  4. a create_rcra_manifest use case ("service") that actually uses the RCRAInfo service

Through this process, we've already created one electronic manifest, although we now we can see some of the errors that RCRAInfo is throwing back at Haztrak. Future front end validation is needed (like for example, if DOT hazardous is true then we need to modify the field name of the "Waste Description" form text box to "dotInformation". There also some work with the "additionalInfo" data that may need polishing. But hey, we're close.

Issue ticket number and link

closes #558
closes #559

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions github-actions bot added client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API) labels Aug 28, 2023
@dpgraham4401 dpgraham4401 merged commit 283b408 into USEPA:main Aug 28, 2023
8 checks passed
@dpgraham4401 dpgraham4401 deleted the create_e-manifest branch August 28, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Save-manifest-task celery task SaveRcraManifestView endpoint
1 participant