Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L-07 [Oval] Missing Input Validation #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

L-07 [Oval] Missing Input Validation #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/oracles/CoinbaseOracle.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ contract CoinbaseOracle is IAggregatorV3SourceCoinbase {
* @param _reporter The address of the reporter allowed to push price data.
*/
constructor(uint8 _decimals, address _reporter) {
require(_reporter != address(0), "Invalid reporter address");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another open PR to fix M-02 that hardcodes the reporter address in the CoinbaseOracle:

oval-contracts/src/oracles/CoinbaseOracle.sol

Line 31 in c2580bf

function reporter() public view virtual returns (address) {
.

If we agree on these changes to fix M-02, L-07 will also be fixed, so probably these changes won’t be required anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. ideally this is all hard coded as it should never change.


decimals = _decimals;
reporter = _reporter;
}
Expand Down
Loading