feat: add maxAge parameter to limit the staleness of a historical data point (run 2) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a point (#14) Signed-off-by: Matt Rice <[email protected]> Signed-off-by: chrismaree <[email protected]> Co-authored-by: chrismaree <[email protected]>
Signed-off-by: Matt Rice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One Oval-related trust vector has surfaced recently. If the oracle is not responsible for keeping snapshots, then someone else is. If that entity allows snapshots to become sufficiently stale, it can lead to the application using very stale prices when a new price comes in.
One idea was to add a maxAge that limits how stale a historical snapshot can be before the current data is used instead.
That's implemented here.
This is a re-do of #14 since that one was merged with build/test errors.