PC-851: Add tests to independently document local authority information #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiehumphries
commented
Feb 16, 2024
| const string fieldName = nameof(LocalAuthorityDetails.Status); | ||
| foreach (var (code, status) in expectedStatusesByCode) | ||
| { | ||
| using var _ = new AssertionScope($"{fieldName} for LA with code \"{code}\""); |
There was a problem hiding this comment.
These assertion scopes mean that the error messages give you details about where in the foreach loop the test failed.
For example:
Expected Status for LA with code "1150" to be Hug2Status.Pending {value: 1}, but found Hug2Status.Live {value: 2}.
rather than just:
Expected localAuthority.Status to be Hug2Status.Live {value: 2}, but found Hug2Status.Pending {value: 1}.
jamiehumphries
commented
Feb 16, 2024
| * The longer term ideal state would be to move this data into the database, but these tests provide a defensive | ||
| * mitigation until that is possible. | ||
| * | ||
| * For full details, see the report attached to: https://beisdigital.atlassian.net/browse/PC-851 |
There was a problem hiding this comment.
This report isn't attached yet, but will be once it is finalised.
jdgage
approved these changes
Feb 16, 2024
jamiehumphries
force-pushed
the
PC-851
branch
from
7973367 to
e76afea
Compare
jamiehumphries
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.