Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-776: New page to support users with non-participating LA #249

Merged

Conversation

Glenn-Clarke
Copy link
Contributor

@Glenn-Clarke Glenn-Clarke commented Feb 12, 2024

Added new page to user journey to support users whose local authority is not participating in sign ups through this service.

The new page captures users who select a local luthority with a HUG2 status of "not participating"
While it currently shows default text, this includes a mechanism to show custom text unique to a local authority.

(Aberdeenshire Council shown for testing purposes. List of LA's in "not participating" has not been changed currently)

image
image

…uthority is not particpating in sign ups through this service. Broadland custom text migrated to "Not Participating" partial.
@Glenn-Clarke Glenn-Clarke force-pushed the PC-776-Create-Customer-Journey-for-Non-Participation-LAs branch from bf6a214 to e517f5f Compare February 19, 2024 09:48
@Glenn-Clarke
Copy link
Contributor Author

@jamiehumphries Is the viewbag.title acceptable? It wasn't confirmed on the Jira ticket, so I've just brought across the same from NotTakingPart.cshtml

"Your local authority is not taking part"

…Enum & checks for forward link. Tidied formatting of custom text switch statement, and NotParticipating.cshtml.
@jamiehumphries
Copy link
Contributor

@Glenn-Clarke, are you going to make the changes to the LocalAuthorityData separately to mark relevant ones as NotParticipating? I know there is still some discussion about Croydon.

@jamiehumphries
Copy link
Contributor

@jamiehumphries Is the viewbag.title acceptable? It wasn't confirmed on the Jira ticket, so I've just brought across the same from NotTakingPart.cshtml

"Your local authority is not taking part"

Thanks for checking this. I think we should use the h1 header from the page, i.e.

Your Local Authority is not receiving applications via this service

I have added a not to PC-776 to confirm.

@Glenn-Clarke
Copy link
Contributor Author

Glenn-Clarke commented Feb 19, 2024

@Glenn-Clarke, are you going to make the changes to the LocalAuthorityData separately to mark relevant ones as NotParticipating? I know there is still some discussion about Croydon.

I've got the changes locally, but I've been holding off on them until confirmation. Would you like me to make them all excluding Croydon, and we can make a separate change to Croydon (or not) once we have confirmation?

@jamiehumphries
Copy link
Contributor

I've got the changes locally, but I've been holding off on them until confirmation. Would you like me to make them all excluding Croydon, and we can make a separate change to Croydon (or not) once we have confirmation?

I think let's make them all including Croydon, as I think the most likely scenario is that they should be NotParticipating.

We can adjust afterwards, as necessary.

@Glenn-Clarke
Copy link
Contributor Author

I've got the changes locally, but I've been holding off on them until confirmation. Would you like me to make them all excluding Croydon, and we can make a separate change to Croydon (or not) once we have confirmation?

I think let's make them all including Croydon, as I think the most likely scenario is that they should be NotParticipating.

We can adjust afterwards, as necessary.

Done :)

@Glenn-Clarke Glenn-Clarke force-pushed the PC-776-Create-Customer-Journey-for-Non-Participation-LAs branch from a475ae4 to 51a9f8d Compare February 19, 2024 16:01
Copy link
Contributor

@jamiehumphries jamiehumphries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markups look good! Go ahead and merge to develop.

@Glenn-Clarke Glenn-Clarke merged commit 8650ee4 into develop Feb 20, 2024
2 checks passed
@Glenn-Clarke Glenn-Clarke deleted the PC-776-Create-Customer-Journey-for-Non-Participation-LAs branch February 20, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants